Add customizable homepage #2648
Conversation
Introduces a new customizable new tab page with clock, greeting, and search bar. Adds settings for enabling/disabling the homepage, choosing between default or custom URL, toggling clock and greeting, and selecting time format. Implements new internal protocols for 'min://newtab' and 'min://blank', updates localization, and refines related CSS and JS for the new tab and settings pages.
Updated the new tab page to use the currently selected search engine instead of a hardcoded DuckDuckGo URL. Added the searchEngine utility script to index.html and modified performSearch to construct the search URL dynamically.
|
Thanks for the PR! I think it makes sense to have a setting to set a custom new tab URL. I'm less convinced that we should have a built-in page. My impression is that there are a lot of potential designs for a new tab page, and people tend to have strong opinions about which design is the best for them; designing something that makes most people happy would require a ton of different customization options and add a lot of complexity. How would you feel about keeping just the setting to set a custom URL, and putting any specific page designs in an external repository? Also, it would be good to figure out a better interaction between the NTP and the searchbar. When I open a new tab, I don't actually see the NTP, because the searchbar is covering it: 
I think this should probably work like this (what do you think?):
|
|
Also, I should point out, we already have an option to set a custom image background on the new tab page: 
We should ensure any changes are compatible with that. |
|
That sounds good to me. I'll remove the new tab page and make it so that in the settings, you can choose either the NTP or a custom URL. A better implemetion of the NTP and the search bar interaction is something I will look into. I think the outline you gave will work well. I'll try to work on this sometime soon, but it might be a week or two. |
This reverts commit 08bf957.
Removed legacy homepage and new tab page code, including blank and custom homepage files and settings. Added new settings for new tab page: blank, custom URL, or background image, with UI and logic updates throughout the app. Updated CSS and JS to support new background image and custom URL options, and removed unused homepage-related code and translations.
|
Everything should be done. I moved the Custom URL into the Additional Settings. There is now a dropdown menu which has three options one for Blank, Custom URL, and NTP. I made sure that both the NTP widget and the preferences functionality are in sync. The changes to the new tab design have been made as well. I think the outline you gave worked great. Let me know if there are any changes or tweaks needed—its looking pretty good to me though. 9b59089 |
2 participants
Introduces a new customizable new tab page with clock, greeting, and search bar. Adds settings for enabling/disabling the homepage, choosing between default or custom URL, toggling clock and greeting, and selecting time format. Implements new internal protocols for 'min://newtab' and 'min://blank', updates localization, and refines related CSS and JS for the new tab and settings pages.
